Use hash join when writing sparkey #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnapz
approved these changes
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5402 +/- ##
==========================================
+ Coverage 61.22% 61.26% +0.03%
==========================================
Files 310 310
Lines 11061 11061
Branches 755 755
==========================================
+ Hits 6772 6776 +4
+ Misses 4289 4285 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing to sparkey,
allShardsrepresents every expected shard even if there is no corresponding data inshardsfor that shard number.shards.rightOuterJoin(allShards)(added in #5208) fails when a shard contains large amounts of data, leading to the error described in #5300:java.lang.OutOfMemoryError: Required array length 2147483639 + 15534 is too large.This PR replaces
rightOuterJoinwithhashFullOuterJoin(note that there is nohashRightOuterJoinimplementation). A hash join is a good fit because the right-hand side contains very little data (only the keys of the shards) and it doesn't need to use an array to represent the large left-hand side's values. As a result, some failing workflows that succeeded in Scio 0.13.* will run successfully again.